Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mission_planner parameter path in static_centerline_generator launch file #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: mission_planner parameter path in static_centerline_generator launch file #218

wants to merge 1 commit into from

Conversation

Ericpotato
Copy link

Description

This PR fix mission_planner parameter path in static_centerline_generator launch file

How was this PR tested?

TIER IV internal link
static path was generated successfully

Notes for reviewers

None.

Effects on system behavior

None.

@Ericpotato
fix static_centerline parameter path
b9173fb 
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

shmpwk
shmpwk approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I confirmed _universe suffix has been applied to the pkg name but has not to the folder name.

@Ericpotato
Copy link
Author

CI failed. It seems it's caused by autoware core

@Ericpotato Ericpotato enabled auto-merge (squash) March 6, 2025 00:31
@Ericpotato
Copy link
Author

@shmpwk Anyway to fix CI fail? The fail is not about the fixing

@shmpwk
Copy link
Contributor

shmpwk commented Mar 7, 2025 •
edited
Loading

Could you check the CI failure more?

Hint: autoware_interpolation build fails and it says autoware_utils/geometry/geometry.hpp does not found.

In file included from /__w/autoware_tools/autoware_tools/dependency_ws/core/autoware.core/common/autoware_interpolation/src/spline_interpolation.cpp:15:
/__w/autoware_tools/autoware_tools/dependency_ws/core/autoware.core/common/autoware_interpolation/include/autoware/interpolation/spline_interpolation.hpp:21:10: fatal error: autoware_utils/geometry/geometry.hpp: No such file or directory
   21 | #include <autoware_utils/geometry/geometry.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/autoware_interpolation.dir/build.make:90: CMakeFiles/autoware_interpolation.dir/src/spline_interpolation.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:157: CMakeFiles/autoware_interpolation.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
--- stderr: autoware_interpolation
In file included from /__w/autoware_tools/autoware_tools/dependency_ws/core/autoware.core/common/autoware_interpolation/src/spline_interpolation.cpp:15:
/__w/autoware_tools/autoware_tools/dependency_ws/core/autoware.core/common/autoware_interpolation/include/autoware/interpolation/spline_interpolation.hpp:21:10: fatal error: autoware_utils/geometry/geometry.hpp: No such file or directory
   21 | #include <autoware_utils/geometry/geometry.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/autoware_interpolation.dir/build.make:90: CMakeFiles/autoware_interpolation.dir/src/spline_interpolation.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:157: CMakeFiles/autoware_interpolation.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---

That bug was fixed here: autowarefoundation/autoware.core#235.
And then ......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk approved these changes

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi

@zusizusi zusizusi Awaiting requested review from zusizusi

Assignees
No one assigned
Labels
component:planning tag:run-build-and-test-differential
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ericpotato @shmpwk